Skip to content

Update code style for Project Euler Problem 28 #2976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 7, 2020
Merged

Update code style for Project Euler Problem 28 #2976

merged 1 commit into from
Oct 7, 2020
+11 −8

Conversation

JasirZaeem
Copy link
Contributor

In reference to Issue #2786

  • Add default arguments
  • Add typehints
  • Rename solution function for Project Euler Problem 28

Describe your change:

  • Fix a bug or typo in an existing algorithm?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints..

@JasirZaeem
Update code style for Project Euler Problem 28
b269277 
Add default arguments, typehints and rename solution function for Porject Euler Problem 28
@dhruvmanila dhruvmanila added the hacktoberfest-accepted Accepted to be counted towards Hacktoberfest label Oct 7, 2020
dhruvmanila
dhruvmanila approved these changes Oct 7, 2020
View reviewed changes
Copy link
Member

@dhruvmanila dhruvmanila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work! Thank you for your contribution.

@dhruvmanila dhruvmanila merged commit 05616ca into TheAlgorithms:master Oct 7, 2020
@JasirZaeem JasirZaeem deleted the patch-1 branch October 8, 2020 05:00
stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
@JasirZaeem @stokhos
Update code style for Project Euler Problem 28 (TheAlgorithms#2976)
d5ae2b0 
Add default arguments, typehints and rename solution function for Porject Euler Problem 28
Panquesito7 pushed a commit to Panquesito7/Python that referenced this pull request May 13, 2021
@JasirZaeem
Update code style for Project Euler Problem 28 (TheAlgorithms#2976)
6677a59 
Add default arguments, typehints and rename solution function for Porject Euler Problem 28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhruvmanila dhruvmanila dhruvmanila approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted Accepted to be counted towards Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JasirZaeem @dhruvmanila